Skip to content

fix(web): align dispatch popover with trigger right edge - #1880

Merged
bobleer merged 1 commit into
GCWing:mainfrom
bobleer:fix/dispatch-popover-alignment
Jul 30, 2026
Merged

fix(web): align dispatch popover with trigger right edge#1880
bobleer merged 1 commit into
GCWing:mainfrom
bobleer:fix/dispatch-popover-alignment

Conversation

@bobleer

@bobleer bobleer commented Jul 30, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Switch dispatch target picker from createPortal + position: fixed to inline position: absolute with right: 0; bottom: calc(100% + 7px), matching the permission-mode popover pattern
  • Replace overflow: auto with overflow-x: hidden; overflow-y: auto to prevent horizontal scrollbar on hover
  • Remove JS-based position computation (computeFixedPopoverPosition, resize/scroll listeners) — CSS-only positioning eliminates the initial-render flash that caused the menu to occasionally appear outside the app window

Test plan

  • Click the dispatch target button — popover should open above, right-aligned with the button's right edge
  • Hover over menu items — no horizontal scrollbar should appear
  • Resize the window while the popover is open — it should stay correctly positioned
  • Open the popover multiple times rapidly — it should never flash at (0, 0) or appear outside the app
  • Verify the permission-mode popover still works correctly (unchanged)

Switch from createPortal + position:fixed to inline position:absolute,
matching the permission-mode popover pattern. Fixes right-alignment,
eliminates the horizontal scrollbar on hover, and prevents the menu
from occasionally rendering outside the app window.
@bobleer
bobleer merged commit 53d369b into GCWing:main Jul 30, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant